ng_ipv6_ext: initial import of extension header handling (including RPL SRH) #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: new feature
This was referenced Apr 30, 2015
miri64
force-pushed
the
ng_ipv6_ext/feat/initial
branch
from
e60c851 to
8383954
Compare
|
Rebased to current master |
| } ng_ipv6_ext_t; | ||
|
|
||
| /** | ||
| * @brief Demultiplex a extension headers according to @p nh. |
There was a problem hiding this comment.
either remove a or make headers singular
cgundogan
added
the
CI: needs squashing
|
I invite you to squash now (: |
miri64
force-pushed
the
ng_ipv6_ext/feat/initial
branch
from
90d3aaf to
0eadaf6
Compare
|
Squashed |
cgundogan
removed
the
CI: needs squashing
|
GO when travis shows green |
|
Am I the only one where https://travis-ci.org/RIOT-OS/RIOT/pull_requests is not loading properly? |
|
@OlegHahm the site is also not loading properly for me. |
|
They updated yesterday night so that might be the reason |
|
Seems to be working again. |
|
@authmillenon, one more thing before the final merge: can you change the last commit message /rpl/ng_rpl/ ? |
miri64
force-pushed
the
ng_ipv6_ext/feat/initial
branch
from
0eadaf6 to
35cf9bf
Compare
|
done |
miri64
force-pushed
the
ng_ipv6_ext/feat/initial
branch
from
35cf9bf to
abc0280
Compare
|
Rebased and adapted to current master, please re-review. |
|
Kicked travis... @cgundogan ping? |
5 tasks
| } | ||
|
|
||
| if (size < NG_IPV6_EXT_LEN_UNIT) { | ||
| return NULL; |
|
Apart from comment: untested re-ACK |
miri64
added a commit
that referenced
this pull request
May 26, 2015
ng_ipv6_ext: initial import of extension header handling (including RPL SRH)
|
Will fix the comment in follow-up. No patience to wait for travis again. |
|
See #3074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2555(merged).